Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the 'wan2.7-image-pro' model by adding a bboxList field to ImageGenerationParam and providing a usage sample. The review feedback suggests adding Javadoc to clarify the complex nested structure of bboxList and using a constant for the model name to improve maintainability.
src/main/java/com/alibaba/dashscope/aigc/imagegeneration/ImageGenerationParam.java
Show resolved
Hide resolved
| public static void wan27ImageUsage() throws NoApiKeyException, UploadFileException { | ||
| ImageGenerationParam param = ImageGenerationParam.builder() | ||
| .apiKey(DASHSCOPE_API_KEY) | ||
| .model("wan2.7-image-pro") |
There was a problem hiding this comment.
The model name "wan2.7-image-pro" is hardcoded as a string literal. It is recommended to define this as a constant in the ImageGeneration.Models class to maintain consistency with other models and avoid magic strings throughout the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.